Add Dockerfile #157
Add Dockerfile #157
Conversation
|
Thanks James, sorry for the slow response. Will get around to testing this probably on the weekend Looks great so far |
| @@ -44,6 +44,24 @@ The import process takes around 10 minutes to complete. | |||
| node server.js // Default environment is development | |||
| ``` | |||
|
|
|||
| ### Running with Docker | |||
|
|
|||
| Postcodes.io is packaged as a Docker container identified on the Docker Hub as `james/postcodes.io`. | |||
There was a problem hiding this comment.
This would probably need to be changed once merged right?
There was a problem hiding this comment.
@billinghamj this is addressed in the notes above.
Note: The automated Docker Hub build james/postcodes.io is currently linked to jamescun/postcodes.io. If merged, either Docker Hub james/postcodes.io will need to be altered to ideal-postcodes/postcodes.io or a new Docker Hub repository needs to be created and the README updated.
|
@jamescun Probably worth adding an trailing new line on the dockerfile. Also might be worth making the default port 80? Docker containers always run as root, so no problems with binding < 1024 |
|
Thanks again, and apologies for the long wait time. Been a bit slammed this past week I've created a docker hub repository at idealpostcodes/postcodes.io and will update the documentation shortly pending checks to pass to point to that Also been able to Also happy to take further PRs if you wish to amend the dockerfile further Great stuff and thanks again! |
|
👍 |
Add a Dockerfile and note in the README about how to use with Docker.
Note: The automated Docker Hub build james/postcodes.io is currently linked to jamescun/postcodes.io. If merged, either Docker Hub james/postcodes.io will need to be altered to ideal-postcodes/postcodes.io or a new Docker Hub repository needs to be created and the README updated.