Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Updated project dependencies and added debug module #70

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rockrotem
Copy link

  • Restored project's git repository URL
  • Replaced console.log usage to debug module (conflicts with central logger instance & performance improvement)
  • Fixed tests to run on local environments
  • Updated lib directory from build

- Restored project's git repository URL
- Replaced `console.log` usage to `debug` module (conflicts with central logger instance & performance improvement)
- Fixed tests to run on local environments
- Updated `lib` directory from build
@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #70 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   96.55%   96.59%   +0.04%     
==========================================
  Files           6        6              
  Lines         145      147       +2     
==========================================
+ Hits          140      142       +2     
  Misses          5        5
Impacted Files Coverage Δ
src/hooks/helpers/path.js 100% <ø> (ø) ⬆️
src/hooks/redis.js 100% <100%> (ø) ⬆️
src/redisClient.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43928bd...383e3af. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 2, 2019

Coverage Status

Coverage increased (+0.05%) to 93.671% when pulling 383e3af on LushaTeam:replace-console-log into 43928bd on idealley:master.

rotem Bloom added 3 commits April 2, 2019 17:02
- Restored project's git repository URL
- Replaced `console.log` usage to `debug` module (conflicts with central logger instance & performance improvement)
- Fixed tests to run on local environments
- Updated `lib` directory from build
- Restored project's git repository URL
- Replaced `console.log` usage to `debug` module (conflicts with central logger instance & performance improvement)
- Fixed tests to run on local environments
- Updated `lib` directory from build
- Reverted change to babel exports that breaks hooks imports
- Restored project's git repository URL
- Replaced `console.log` usage to `debug` module (conflicts with central logger instance & performance improvement)
- Fixed tests to run on local environments
- Updated `lib` directory from build
- Reverted change to babel exports that breaks hooks imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants