Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyWavelets dependency to 1.1.1 #107

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

Emilv2
Copy link
Contributor

@Emilv2 Emilv2 commented Oct 2, 2020

running pytest tests/test_hashing.py::test_find_duplicates_encoding_map_input
shows that PyWavelets 1.0.3 will stop working in python 3.9:

DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated since Python 3.3,
and in 3.9 it will stop working from collections import Iterable

Updating PyWavelets to 1.1.1 fixes this.

running pytest tests/test_hashing.py::test_find_duplicates_encoding_map_input
shows that PyWavelets 1.0.3 will stop working in python 3.9:

DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated since Python 3.3,
and in 3.9 it will stop working from collections import Iterable

updating PyWavelets to 1.1.1 fixes this.
Copy link
Collaborator

@tanujjain tanujjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Can be merged to dev.

Copy link
Collaborator

@datitran datitran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. Can be merged.

@tanujjain tanujjain merged commit 6e366d5 into idealo:dev Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants