Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close figure after plotting to avoid figure overwrite #111

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Conversation

tanujjain
Copy link
Collaborator

WHAT

Refers to issue #100.
plot_duplicates, when used repeatedly in a loop (to plot duplicates for many images repeatedly), might lead to overwriting some wrong images in consecutive plots. The error doesn't seem to have reproducibility, but is a general observation with matplotlib.

WHY

Wrong images should not be plotted as duplicates.

HOW

Closing the plot after showing.

CHANGES

  • Addition of plt.close() to close images.
  • No suitable test cases could be written to check the behaviour.

@tanujjain tanujjain added the next release All the issues, PRs that are targeted to be the part of next release of the package. label Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release All the issues, PRs that are targeted to be the part of next release of the package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants