Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numpy as an explicit dependency and ensure pip dependency resolver works as expected #119

Merged
merged 2 commits into from
Nov 23, 2020

Conversation

tanujjain
Copy link
Collaborator

WHAT

Allow tensorflow to install appropriate numpy version and ensure that package can be installed without error using 2020-resolver that helps pip resolve dependencies from October 2020 onwards.

WHY

  • Depending upon the tensorflow version installed, specific numpy versions need to be available. Therefore, tensorflow should be allowed to install the appropriate version instead of any explicit numpy version mandated by the imagededup package.
  • As per the announcement, new versions of pip (October 2020 onwards) will resolve dependencies in a way different than before. So, it is required to ensure than pip installing the package with --use-feature=2020-resolver works without issue.

HOW

  • Remove explicit numpy installation.
  • Build package locally with pip install . --use-feature=2020-resolver

On the test system: macOS Mojave 10.14.6, python 3.8, conda environment, using above command leads to following explicit package versions(only packages explicitly imported within the codebase mentioned below):

numpy==1.18.5
Pillow==6.2.2
PyWavelets==1.1.1
scikit-learn==0.23.2
scipy==1.5.4
tensorflow==2.3.1
tqdm==4.53.0

All tests are passing with these changes.

…ackage can be installed without error using 2020-resolver that helps pip resolves dependencies from October 2020 onwards.
@datitran datitran merged commit 8f7185d into dev Nov 23, 2020
@tanujjain tanujjain deleted the depedency/tf-numpy branch October 28, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants