Port CNN to pytorch, other major changes #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… maps to lanczos in latest pillow versions. Also fix tests to adapt cnn scores, hashes.
…f pytorch mobilenet v3 instead of tensorflow mobilenetv2.
…n 2022). Also update description to reflect python version support.
tanujjain
added a commit
that referenced
this pull request
Oct 14, 2022
…ngs (#175) * Bump version to 0.2.4. * Update builtin.h (#123) * Update readme to reflect changes in TF 2.1. * Bump version to 0.2.4. (#122) * Update builtin.h respelled keyword as taking to some malicious site. Co-authored-by: Dat Tran <datitran@gmail.com> Co-authored-by: Tanuj Jain <tanujjain@users.noreply.github.com> * Add recursive option in encode_image() (#104) * Update tests for new recursive option * Add recursive option to the following functions: encode_image() find_duplicates() find_duplicates_to_remove() Recusive is off by default. * Add tests for recursive option * Modify tests to ignore hidden files '.DS_Store' that are automatically created on mac by the Finder application. (#131) * Port CNN to pytorch, other major changes (#173) * Add feature generation with mobilenet v3. * Integrate multi image encoding generation in CNN class. * Update tests to adhere to new cnn embeddings as well as new hashes generated. * Change antialias resampling to lanczos as antialias is deprecated and maps to lanczos in latest pillow versions. Also fix tests to adapt cnn scores, hashes. * Clean up code to consolidate preprocessing in one place. * Add tests for data generator. * Update documentation to reflect the changes occurring due to the use of pytorch mobilenet v3 instead of tensorflow mobilenetv2. * Update readme to remove tensorflow specifics. * Update version for Pillow to be minimum 9.0 (released beginning of Jan 2022). Also update description to reflect python version support. * Update requirements.txt and do some cleanup. * Update travis and azure-pipelines os versions. Co-authored-by: danidavid <33230485+danidavid@users.noreply.github.com> Co-authored-by: Dat Tran <datitran@gmail.com> Co-authored-by: Emilv2 <emil@vanherp.me>
|
Wait, does this mean 0.3.0 doesn't support generating with the GPU? That wasn't mentioned in the release notes. |
Not at the moment, but the fix has already been merged to dev branch. Will be creating a new release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pull request comes with major changes.
Supported Python versions
Python 3.6has been withdrawn (Several major dependencies have withdrawn support forPython 3.6, includingscipy,Pillow-9.0+,matplotlib-3.6)Python 3.7will reach end-of-life on 2023-06-27. Hence,Python 3.7is also not supported.CNN
tensorflowto pytorch (supported throughtorchvision).MobilenetV3instead ofMobilenetv2.Hashing
resizefunction ofPillowover several versions, the hashing methods do not yield the same hashes as the previous versions of imagededup (which forcedPillowversion to be<7.0.0). This leads to different hashes being generated for the same image across different imagededup versions. (All hashing methods are impacted since they all rely upon Pillow's resizing method). The hashes work reliably, so there's no impact on the functionality per se.Todos after this PR has been merged