Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert @idearium/safe-promise to an ESM #371

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Convert @idearium/safe-promise to an ESM #371

merged 3 commits into from
Mar 5, 2024

Conversation

smebberson
Copy link
Member

@smebberson smebberson commented Mar 4, 2024 •
edited
Loading

This PR turns @idearium/safe-promise into an ESM.

Testing

Do this on Next.js using ESM.

  • Install the latest version with yarn add -E @idearium/safe-promise@beta.
  • Ensure v2.0.0-beta.1 is installed.
  • Import the package with import { safePromise } from '@idearium/safe-promise';.
  • Write some code that uses the package and make sure it works.

Deployment

  • Version bump.
  • Do a v2.0.0 release on GitHub.

@smebberson smebberson marked this pull request as ready for review March 4, 2024 23:13
@smebberson smebberson merged commit da01ced into master Mar 5, 2024
86 checks passed
@smebberson smebberson deleted the safe-promise-esm branch March 5, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanchau allanchau allanchau approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smebberson @allanchau