Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDEMPIERE-5305 : ORA-01704: string literal too long when trying to up… #1353

Merged
merged 1 commit into from Jun 2, 2022
Merged

IDEMPIERE-5305 : ORA-01704: string literal too long when trying to up… #1353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 8 additions & 15 deletions org.adempiere.base/src/org/compiere/model/PO.java
View file
Open in desktop
Expand Up @@ -4049,26 +4049,16 @@ && is_ValueChanged(p_info.getColumnName(i)))
.append(tableName).append("_Trl SET ");

//
ArrayList<Object> values = new ArrayList<Object>();
StringBuilder sqlcols = new StringBuilder();
for (int i = 0; i < p_info.getColumnCount(); i++)
{
String columnName = p_info.getColumnName(i);
if (p_info.isColumnTranslated(i)
&& is_ValueChanged(columnName))
{
sqlcols.append(columnName).append("=");
Object value = get_Value(columnName);
if (value == null)
sqlcols.append("NULL");
else if (value instanceof String)
sqlcols.append(DB.TO_STRING((String)value));
else if (value instanceof Boolean)
sqlcols.append(((Boolean)value).booleanValue() ? "'Y'" : "'N'");
else if (value instanceof Timestamp)
sqlcols.append(DB.TO_DATE((Timestamp)value));
else
sqlcols.append(value.toString());
sqlcols.append(",");
sqlcols.append(columnName).append("=?,");
values.add(get_Value(columnName));

// Reset of related translation cache entries
String[] availableLanguages = Language.getNames();
Expand All @@ -4088,6 +4078,9 @@ else if (value instanceof Timestamp)
int no = -1;

try {
Object[] params = new Object[values.size()];
values.toArray(params);

if (client.isMultiLingualDocument()) {
if (client.getAD_Language().equals(baselang)) {
// tenant language = base language
Expand All @@ -4108,7 +4101,7 @@ else if (value instanceof Timestamp)
.append("IsTranslated='Y'")
.append(whereid)
.append(getAD_Client_ID() == 0 ? andBaseLang : andClientLang);
no = DB.executeUpdateEx(sqlexec.toString(), m_trxName);
no = DB.executeUpdateEx(sqlexec.toString(), params, m_trxName);
if (log.isLoggable(Level.FINE)) log.fine("#" + no);
if (no >= 0) {
// set other translations as untranslated
Expand All @@ -4129,7 +4122,7 @@ else if (value instanceof Timestamp)
.append(sqlcols)
.append("IsTranslated='Y'")
.append(whereid);
no = DB.executeUpdateEx(sqlexec.toString(), m_trxName);
no = DB.executeUpdateEx(sqlexec.toString(), params, m_trxName);
if (log.isLoggable(Level.FINE)) log.fine("#" + no);
}
} catch (DBException e) {
Expand Down