Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDEMPIERE-5545 MenuElementHandler generating statements with bind variables in migration script #1639

Merged
merged 1 commit into from Jan 15, 2023
Merged

IDEMPIERE-5545 MenuElementHandler generating statements with bind variables in migration script #1639

merged 1 commit into from Jan 15, 2023

Conversation

CarlosRuiz-globalqss
Copy link
Collaborator

https://idempiere.atlassian.net/browse/IDEMPIERE-5545

Checklist:

  • My code follows the code guidelines of this project
  • My code follows the best practices of this project
  • I have performed a self-review of my own code
  • My code is easy to understand and review.
  • In hard-to-understand areas, I have commented my code.
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have added unit tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

hengsin
hengsin approved these changes Jan 15, 2023
View reviewed changes
Copy link
Collaborator

@hengsin hengsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial fix, good to go

@hengsin hengsin merged commit 0d1ef0a into idempiere:master Jan 15, 2023
CarlosRuiz-globalqss added a commit that referenced this pull request Jan 18, 2023
@CarlosRuiz-globalqss
IDEMPIERE-5545 MenuElementHandler generating statements with bind var…
6676a4e 
…iables in migration script (#1639)
@CarlosRuiz-globalqss CarlosRuiz-globalqss deleted the IDEMPIERE-5545 branch February 8, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengsin hengsin hengsin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@CarlosRuiz-globalqss @hengsin