Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEMPIERE-5528 IDEMPIERE-5560 Cannot save more than one order line when an _ID field is not displayed #1763

Merged
merged 1 commit into from Apr 1, 2023

Conversation

CarlosRuiz-globalqss
Copy link
Collaborator

https://idempiere.atlassian.net/browse/IDEMPIERE-5560#icft=IDEMPIERE-5560

https://idempiere.atlassian.net/browse/IDEMPIERE-5528

Pull Request Checklist

  • My code follows the code guidelines of this project
  • My code follows the best practices of this project
  • I have performed a self-review of my own code
  • My code is easy to understand and review.
  • I have checked my code and corrected any misspellings
  • In hard-to-understand areas, I have commented my code.
  • My changes generate no new warnings

Tests

  • I have tested the direct scenario that my code is solving
  • I checked all collaterals that can be affected by my changes, and tested other potential affected scenarios
  • New and existing unit tests pass locally with my changes
  • I have added unit tests that prove my fix is effective or that my feature works

@CarlosRuiz-globalqss
Copy link
Collaborator Author

Hi @hengsin - this is a unit test case to illustrate the failure caused by IDEMPIERE-5528 that was described in IDEMPIERE-5560

I needed to add a call to Login.loadPreferences to enable the grid window for sales order to behave as expected filling the default sales order doc type with a preference.

Also, I created an internal DataStatusListener in line 215.
NOTE: I think it would be good to create a dedicated generic class to open a window, set a DataStatusListener, etc.

Also, for some reason the change on AD_Field is not taken unless I commit it, I guess somewhere in the GridWindow/GridTab definition is reading out of transaction.

Copy link
Collaborator

@hengsin hengsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@hengsin hengsin merged commit 09df36a into idempiere:master Apr 1, 2023
4 checks passed
@CarlosRuiz-globalqss CarlosRuiz-globalqss deleted the IDEMPIERE-5528 branch April 4, 2023 18:58
CarlosRuiz-globalqss added a commit that referenced this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants