Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDEMPIERE-5666 - Prevent Closing the Tab of a Running Report #1778

Merged
merged 4 commits into from Apr 14, 2023
Merged

IDEMPIERE-5666 - Prevent Closing the Tab of a Running Report #1778

merged 4 commits into from Apr 14, 2023

Conversation

PeterTakacs300
Copy link
Contributor

JIRA ticket: https://idempiere.atlassian.net/browse/IDEMPIERE-5666

Pull Request Checklist

  • My code follows the code guidelines of this project
  • My code follows the best practices of this project
  • I have performed a self-review of my own code
  • My code is easy to understand and review.
  • In hard-to-understand areas, I have commented my code.
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have added unit tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have made corresponding changes to the documentation as follows:
    • New feature (non-breaking change which adds functionality): I have created the New Feature page in the project wiki explaining the functionality and how to use it. If relevant, I have committed sample data to the core seed to have usable examples in GardenWorld.
    • Breaking change (fix or feature that would cause existing functionality to not work as expected): I have documented the change in a clear way that everyone in the community can understand the impact of the change.
    • Improvement (improves and existing functionality): This documentation is needed if the improvement changes the way the user interacts with the system or the outcome of a process/task changes. If it is just, for instance, a performance improvement, documentation might not be needed.
  • The changed/added documentation is in the project wiki (not privately-hosted pdf files or links pointing to a company website) and is complete and self-explanatory.

@PeterTakacs300 PeterTakacs300 changed the title Idempiere 5666 IDEMPIERE-5666 - Prevent Closing the Tab of a Running Report Apr 12, 2023
@hengsin
Copy link
Collaborator

hengsin commented Apr 14, 2023

pr1778.patch1.txt

hengsin
hengsin requested changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@hengsin hengsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review attached patch, thanks.

@PeterTakacs300
Copy link
Contributor Author

patch reviewed, applied

hengsin
hengsin approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@hengsin hengsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@hengsin hengsin merged commit 4789170 into idempiere:master Apr 14, 2023
4 checks passed
@PeterTakacs300 PeterTakacs300 deleted the IDEMPIERE-5666 branch April 14, 2023 13:49
CarlosRuiz-globalqss pushed a commit that referenced this pull request Apr 23, 2023
@PeterTakacs300 @CarlosRuiz-globalqss
IDEMPIERE-5666 - Prevent Closing the Tab of a Running Report (#1778)
c515be8 
* IDEMPIERE-5666 - Prevent Closing the Tab of a Running Report

* IDEMPIERE-5666 - fix javascript error

* IDEMPIERE-5666 - pr1778 patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengsin hengsin hengsin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@PeterTakacs300 @hengsin