Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEMPIERE-5701: Improve logs when role cannot report or export #1811

Merged
merged 2 commits into from May 3, 2023

Conversation

nmicoud
Copy link
Contributor

@nmicoud nmicoud commented Apr 28, 2023

https://idempiere.atlassian.net/browse/IDEMPIERE-5701

Pull Request Checklist

  • My code follows the code guidelines of this project
  • My code follows the best practices of this project
  • I have performed a self-review of my own code
  • My code is easy to understand and review.
  • I have checked my code and corrected any misspellings
  • In hard-to-understand areas, I have commented my code.
  • My changes generate no new warnings

Tests

  • I have tested the direct scenario that my code is solving
  • I checked all collaterals that can be affected by my changes, and tested other potential affected scenarios
  • New and existing unit tests pass locally with my changes
  • I have added unit tests that prove my fix is effective or that my feature works

Documentation

  • I have made corresponding changes to the documentation as follows:
    • New feature (non-breaking change which adds functionality): I have created the New Feature page in the project wiki explaining the functionality and how to use it. If relevant, I have committed sample data to the core seed to have usable examples in GardenWorld.
    • Breaking change (fix or feature that would cause existing functionality to not work as expected): I have documented the change in a clear way that everyone in the community can understand the impact of the change.
    • Improvement (improves and existing functionality): This documentation is needed if the improvement changes the way the user interacts with the system or the outcome of a process/task changes. If it is just, for instance, a performance improvement, documentation might not be needed.
  • The changed/added documentation is in the project wiki (not privately-hosted pdf files or links pointing to a company website) and is complete and self-explanatory.

@CarlosRuiz-globalqss
Copy link
Collaborator

Hi @nmicoud - can you please apply the next patch:
pr1811PR.patch.txt

When I'm setting a role as IsCanReport=N, the system is showing in console hundreds of warnings "MRole.isCanReport: Role denied"

This must not be a warning, this is a configuration that I chose, so I'm suggesting to decrease the log level to fine.

Also, the patch hides the report button on windows when the role doesn't allow it.

…d hide Report button when role cannot report

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>
Copy link
Collaborator

@CarlosRuiz-globalqss CarlosRuiz-globalqss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@CarlosRuiz-globalqss CarlosRuiz-globalqss merged commit 0553878 into idempiere:master May 3, 2023
4 checks passed
CarlosRuiz-globalqss added a commit that referenced this pull request May 5, 2023
* IDEMPIERE-5701: Improve logs when role cannot report or export

https://idempiere.atlassian.net/browse/IDEMPIERE-5701

* IDEMPIERE-5701: Reduce log level when role cannot report or export and hide Report button when role cannot report

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants