IDEMPIERE-5703 NPE when importing Physical Inventory using Import CSV button #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hengsin
requested changes
May 1, 2023
| MInventory inventory = new MInventory(ctx, (Integer) mTab.getValue("M_Inventory_ID"), trxName); | ||
| int invId = 0; | ||
| if (mTab.getValue("M_Inventory_ID") != null) | ||
| invId = (Integer) mTab.getValue("M_Inventory_ID"); |
There was a problem hiding this comment.
should immediate return null if mTab.getValue("M_Inventory_ID") is null
There was a problem hiding this comment.
Thanks @hengsin - committed your suggestion
CarlosRuiz-globalqss
force-pushed
the
IDEMPIERE-5703
branch
from
3f51094
to
778d2e9
Compare
hengsin
approved these changes
May 1, 2023
CarlosRuiz-globalqss
added a commit
that referenced
this pull request
May 1, 2023
… button (#1813) * IDEMPIERE-5703 NPE when importing Physical Inventory using Import CSV button * - implement better approach suggested by Heng Sin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://idempiere.atlassian.net/browse/IDEMPIERE-5703
Pull Request Checklist
Tests