Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEMPIERE-5758 Improve extensibility of ReplenishReportProduction #1879

Merged

Conversation

CarlosRuiz-globalqss
Copy link
Collaborator

Pull Request Checklist

  • My code follows the code guidelines of this project
  • My code follows the best practices of this project
  • I have performed a self-review of my own code
  • My code is easy to understand and review.
  • I have checked my code and corrected any misspellings
  • In hard-to-understand areas, I have commented my code.
  • My changes generate no new warnings

Tests

  • I have tested the direct scenario that my code is solving
  • I checked all collaterals that can be affected by my changes, and tested other potential affected scenarios
  • New and existing unit tests pass locally with my changes
  • I have added unit tests that prove my fix is effective or that my feature works

Copy link
Contributor

@d-ruiz d-ruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It is similar to what was done in this commit for ComissionCalc

@CarlosRuiz-globalqss CarlosRuiz-globalqss merged commit 0ae4898 into idempiere:master Jun 6, 2023
4 checks passed
@CarlosRuiz-globalqss CarlosRuiz-globalqss deleted the IDEMPIERE-5758 branch June 6, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants