Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEMPIERE-5816 Upgrade Hazelcast version (FHCA-4436) #1957

Merged
merged 1 commit into from Jul 29, 2023

Conversation

CarlosRuiz-globalqss
Copy link
Collaborator

https://idempiere.atlassian.net/browse/IDEMPIERE-5816

  • fix NPE when no hazelcast.xml file is in path or in bundle
  • remove the library hazelcast-aws.jar - not needed anymore

I conducted tests with two amazon instances and it worked fine without the library as those classes are now included in hazelcast.jar

- fix NPE when no hazelcast.xml file is in path or in bundle
- remove the library hazelcast-aws.jar - not needed anymore
Copy link
Collaborator

@hengsin hengsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@hengsin hengsin merged commit f4561e6 into idempiere:master Jul 29, 2023
4 checks passed
@CarlosRuiz-globalqss CarlosRuiz-globalqss deleted the IDEMPIERE-5816 branch July 29, 2023 16:27
CarlosRuiz-globalqss added a commit that referenced this pull request Jul 29, 2023
- fix NPE when no hazelcast.xml file is in path or in bundle
- remove the library hazelcast-aws.jar - not needed anymore
freddyheredia4 pushed a commit to freddyheredia4/idempiere that referenced this pull request Feb 28, 2024
- fix NPE when no hazelcast.xml file is in path or in bundle
- remove the library hazelcast-aws.jar - not needed anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants