Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDEMPIERE-5860 Recent Item of Window Customization is usually empty #2017

Merged
merged 3 commits into from Sep 20, 2023
Merged

IDEMPIERE-5860 Recent Item of Window Customization is usually empty #2017

merged 3 commits into from Sep 20, 2023

Conversation

CarlosRuiz-globalqss
Copy link
Collaborator

https://idempiere.atlassian.net/browse/IDEMPIERE-5860

Pull Request Checklist

  • My code follows the code guidelines of this project
  • My code follows the best practices of this project
  • I have performed a self-review of my own code
  • My code is easy to understand and review.
  • I have checked my code and corrected any misspellings
  • In hard-to-understand areas, I have commented my code.
  • My changes generate no new warnings

Tests

  • I have tested the direct scenario that my code is solving
  • I checked all collaterals that can be affected by my changes, and tested other potential affected scenarios
  • New and existing unit tests pass locally with my changes
  • I have added unit tests that prove my fix is effective or that my feature works

@CarlosRuiz-globalqss CarlosRuiz-globalqss marked this pull request as draft September 20, 2023 09:42
@CarlosRuiz-globalqss CarlosRuiz-globalqss marked this pull request as ready for review September 20, 2023 09:47
hengsin
hengsin approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@hengsin hengsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@hengsin hengsin merged commit b5acb53 into idempiere:master Sep 20, 2023
4 checks passed
CarlosRuiz-globalqss added a commit that referenced this pull request Oct 1, 2023
@CarlosRuiz-globalqss
IDEMPIERE-5860 Recent Item of Window Customization is usually empty (#…
848c1ac 
…2017)

* IDEMPIERE-5860 Recent Item of Window Customization is usually empty

* - move to iD10

* - apply the same for Process and Info Window Customization
@CarlosRuiz-globalqss CarlosRuiz-globalqss deleted the IDEMPIERE-5860 branch October 3, 2023 11:18
freddyheredia4 pushed a commit to freddyheredia4/idempiere that referenced this pull request Feb 28, 2024
@CarlosRuiz-globalqss @freddyheredia4
IDEMPIERE-5860 Recent Item of Window Customization is usually empty (i…
747987f 
…dempiere#2017)

* IDEMPIERE-5860 Recent Item of Window Customization is usually empty

* - move to iD10

* - apply the same for Process and Info Window Customization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengsin hengsin hengsin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@CarlosRuiz-globalqss @hengsin