Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEMPIERE-5877 Include .sh scripts in windows installer #2044

Merged
merged 2 commits into from Oct 5, 2023

Conversation

CarlosRuiz-globalqss
Copy link
Collaborator

@CarlosRuiz-globalqss CarlosRuiz-globalqss commented Oct 3, 2023

https://idempiere.atlassian.net/browse/IDEMPIERE-5877

Pull Request Checklist

  • My code follows the code guidelines of this project
  • My code follows the best practices of this project
  • I have performed a self-review of my own code
  • My code is easy to understand and review.
  • I have checked my code and corrected any misspellings
  • In hard-to-understand areas, I have commented my code.
  • My changes generate no new warnings

Tests

  • I have tested the direct scenario that my code is solving
  • I checked all collaterals that can be affected by my changes, and tested other potential affected scenarios
  • New and existing unit tests pass locally with my changes
  • I have added unit tests that prove my fix is effective or that my feature works

- adapt getVar.sh for windows - as there is no .idpass in windows
@CarlosRuiz-globalqss CarlosRuiz-globalqss marked this pull request as ready for review October 4, 2023 14:25
@CarlosRuiz-globalqss
Copy link
Collaborator Author

This is ready.

I conducted full installation in windows-10 and linux too after these changes, both worked fine.

Windows Tests were done in two different ways:

PREREQUISITE: add to environment variable Path the folder C:\Program Files\PostgreSQL\15\bin

1 - pure git bash:

  • git bash
    cd c:/idempiere
    bash setup-alt.sh
    cd utils
    bash RUN_ImportIdempiere.sh
    bash RUN_SyncDB.sh
    cd ..
    bash sign-database-build-alt.sh
    bash idempiere-server.sh

2 - combined BAT and bash

  • Windows-CMD
    cd c:\idempiere
    setup.bat
    RUN_ImportIdempiere.bat
    cd ..
    sign-database-build-alt.bat
    NOTE: there is no way to run syncdb in windows, then
  • git bash
    cd c:/idempiere/utils
    RUN_SyncDB.sh

BOTH tests were successful and worked fine after the changes on this ticket.

The installation in linux was also succesful.

Copy link
Collaborator

@hengsin hengsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@hengsin hengsin merged commit 64b9415 into idempiere:master Oct 5, 2023
4 checks passed
CarlosRuiz-globalqss added a commit that referenced this pull request Oct 6, 2023
* IDEMPIERE-5877 Include .sh scripts in windows installer

* - adapt build.xml for windows running with git bash
- adapt getVar.sh for windows - as there is no .idpass in windows
@CarlosRuiz-globalqss CarlosRuiz-globalqss deleted the IDEMPIERE-5877 branch October 30, 2023 13:34
freddyheredia4 pushed a commit to freddyheredia4/idempiere that referenced this pull request Feb 28, 2024
* IDEMPIERE-5877 Include .sh scripts in windows installer

* - adapt build.xml for windows running with git bash
- adapt getVar.sh for windows - as there is no .idpass in windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants