IDEMPIERE-5893 Completed invoices are being updated in MOrder.afterSave #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test for date and ID
hengsin
reviewed
Oct 27, 2023
| COLUMNNAME_PaymentRule, | ||
| COLUMNNAME_C_PaymentTerm_ID, | ||
| COLUMNNAME_DateAcct}; | ||
| boolean propagateColChanged = false; |
There was a problem hiding this comment.
what would be the options available if an implementation wish to change the auto propagate columns ?
There was a problem hiding this comment.
more columns can be propagated with an EventHandler
less columns or a different document status would not be possible, maybe an EventHandler on MInvoice to capture the change and reset it back to the old value?
any suggestion?
There was a problem hiding this comment.
perhaps as a new sysconfig entry ?
There was a problem hiding this comment.
perhaps as a new sysconfig entry ?
ready, changed the approach to use SysConfig ORDER_COLUMNS_TO_COPY_TO_NOT_COMPLETED_INVOICES
… as suggested by Heng Sin
CarlosRuiz-globalqss
added a commit
that referenced
this pull request
Oct 29, 2023
…ve (#2075) * IDEMPIERE-5893 Completed invoices are being updated in MOrder.afterSave * - refactor - test for date and ID * - implement SysConfig ORDER_COLUMNS_TO_COPY_TO_NOT_COMPLETED_INVOICES as suggested by Heng Sin
freddyheredia4
pushed a commit
to freddyheredia4/idempiere
that referenced
this pull request
Feb 28, 2024
…ve (idempiere#2075) * IDEMPIERE-5893 Completed invoices are being updated in MOrder.afterSave * - refactor - test for date and ID * - implement SysConfig ORDER_COLUMNS_TO_COPY_TO_NOT_COMPLETED_INVOICES as suggested by Heng Sin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://idempiere.atlassian.net/browse/IDEMPIERE-5893
Pull Request Checklist
Tests