Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDEMPIERE-5782 Generated Shipments/MR and Invoices with Invalid SalesRep #2127

Merged
merged 2 commits into from Dec 5, 2023
Merged

IDEMPIERE-5782 Generated Shipments/MR and Invoices with Invalid SalesRep #2127

merged 2 commits into from Dec 5, 2023

Conversation

CarlosRuiz-globalqss
Copy link
Collaborator

https://idempiere.atlassian.net/browse/IDEMPIERE-5782

  • Fix same issue with RMA

Pull Request Checklist

  • My code follows the code guidelines of this project
  • My code follows the best practices of this project
  • I have performed a self-review of my own code
  • My code is easy to understand and review.
  • I have checked my code and corrected any misspellings
  • In hard-to-understand areas, I have commented my code.
  • My changes generate no new warnings

Tests

  • I have tested the direct scenario that my code is solving
  • I checked all collaterals that can be affected by my changes, and tested other potential affected scenarios
  • New and existing unit tests pass locally with my changes
  • I have added unit tests that prove my fix is effective or that my feature works

hengsin
hengsin approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@hengsin hengsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@hengsin hengsin merged commit d612159 into idempiere:master Dec 5, 2023
4 checks passed
@CarlosRuiz-globalqss CarlosRuiz-globalqss deleted the IDEMPIERE-5782 branch December 7, 2023 13:01
CarlosRuiz-globalqss added a commit that referenced this pull request Dec 11, 2023
@CarlosRuiz-globalqss
IDEMPIERE-5782 Generated Shipments/MR and Invoices with Invalid Sales…
9a885ac 
…Rep (#2127)

* IDEMPIERE-5782 Generated Shipments/MR and Invoices with Invalid Sales Rep

- Fix same issue with RMA

* - add the callout validations also on beforeSave
freddyheredia4 pushed a commit to freddyheredia4/idempiere that referenced this pull request Feb 28, 2024
@CarlosRuiz-globalqss @freddyheredia4
IDEMPIERE-5782 Generated Shipments/MR and Invoices with Invalid Sales…
7c556f7 
…Rep (idempiere#2127)

* IDEMPIERE-5782 Generated Shipments/MR and Invoices with Invalid Sales Rep

- Fix same issue with RMA

* - add the callout validations also on beforeSave
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengsin hengsin hengsin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@CarlosRuiz-globalqss @hengsin