IDEMPIERE-5994 Connection leak when using DB.prepareStatement(badSql, null)

[CarlosRuiz-globalqss]

https://idempiere.atlassian.net/browse/IDEMPIERE-5994

Pull Request Checklist

• My code follows the code guidelines of this project
• My code follows the best practices of this project
• I have performed a self-review of my own code
• My code is easy to understand and review.
• I have checked my code and corrected any misspellings
• In hard-to-understand areas, I have commented my code.
• My changes generate no new warnings

Tests

• I have tested the direct scenario that my code is solving
• I checked all collaterals that can be affected by my changes, and tested other potential affected scenarios
• New and existing unit tests pass locally with my changes
• I have added unit tests that prove my fix is effective or that my feature works

[hengsin]

doesn't need the localConn stuff, just need to call this.close() here.

[CarlosRuiz-globalqss]

Hi @hengsin
this.close() is not available at this point
the "localconn" is to avoid closing a connection that is managed elsewhere, I just need to close here the connections created locally in the same method.

[hengsin]

ok, you need to change StatementProxy.close to protected. Calling the close method of StatementProxy should be the correct approach here, not the method above.

[CarlosRuiz-globalqss]

Thanks @hengsin - tested your suggestion and it worked fine.

[hengsin]

ok, you need to change StatementProxy.close to protected. Calling the close method of StatementProxy should be the correct approach here, not the method above.

[hengsin]

looks good