Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEMPIERE-4811 Custom Toolbar Buttons Dynamic Validation Fix #704

Merged
merged 2 commits into from Jun 3, 2021

Conversation

igorpojzl
Copy link
Contributor

Ticket: https://idempiere.atlassian.net/browse/IDEMPIERE-4811

Expanded ToolbarCustomButton class to set tabNo when rendered on Tab Detail Pane to have access to tab Context.
Expanded DetailPane on method updateToolbar to use ToolbarCustomButton.dynamicDisplay() when toolbarbutton is CustomToolbarButton.

Copy link
Collaborator

@hengsin hengsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@hengsin hengsin merged commit 5f24066 into idempiere:master Jun 3, 2021
@igorpojzl igorpojzl deleted the IDEMPIERE-4811 branch June 3, 2021 14:40
CarlosRuiz-globalqss pushed a commit that referenced this pull request Jun 4, 2021
* IDEMPIERE-4811 Custom Tolbar Buttons Dynamic Validation on Detail Pane Fix

* IDEMPIERE-4811 ToolbarCustomButton - update old constructor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants