PID-676: support hash interface for poseidon; support golang crypto interfaces… #55
Conversation
babyjub/babyjub_wrapper_test.go
Outdated
| require.False(t, x1.Equal(x2)) | ||
| } | ||
|
|
||
| func decomrpessSig(commpresedSig []byte) (*Signature, error) { |
There was a problem hiding this comment.
Fix name: decompressSig
Also, maybe it makes sense to have it public and in library instead of test?
There was a problem hiding this comment.
Done.
I renamed and made this function public.
poseidon/poseidon_wrapper.go
Outdated
|
|
||
| // NewPoseidon returns the Poseidon hash of the input bytes. | ||
| // use frame size of 16 inputs by default | ||
| func NewPoseidon(b []byte) []byte { |
There was a problem hiding this comment.
Name of this function is weird. It's not instantiating new poseidon hasher, it performs hashing instead. I think we don't need it at all.
There was a problem hiding this comment.
Take a look at New* functions in https://pkg.go.dev/golang.org/x/crypto/sha3#pkg-index and usage examples. Also we need to test that writing data ('h.Write`) in multiple steps with different input sizes still works.
There was a problem hiding this comment.
Done. Sync with x/crypto and /crypto libs.
Add unit test of h.Write in multiple steps.
poseidon/poseidon_wrapper.go
Outdated
| return d.buf.Write(p) | ||
| } | ||
|
|
||
| // Sum returns the Poseidon checksum of the data. |
There was a problem hiding this comment.
not checksum, but hash digest
poseidon/poseidon_wrapper.go
Outdated
| "hash" | ||
| ) | ||
|
|
||
| type digest struct { |
There was a problem hiding this comment.
It's not a digest. Need a better name, maybe hasher
No description provided.