Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup logs #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

danilopeixoto
Copy link

@danilopeixoto danilopeixoto commented Aug 14, 2022

Remove b'\n' from logs.

@danlester
Copy link
Member

Thank you for this. It looks very helpful, although my only concern is that .decode().strip() could potentially result in an exception. I'm not sure if this is true - I haven't looked into it, in terms of possible unexpected values of line that could lead to that scenario. Do you have any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants