[7.3.0] Fixed destroy in IE 11 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idiotWu
requested changes
May 26, 2017
|
Ok, removed dist! |
idiotWu
approved these changes
May 26, 2017
|
Much thanks! Will release 7.3.1 soon. |
|
Yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced the deletion of innerHTML with a loop, cause the deletion would also empty the content of the saved elements in IE, which resulted in empty DOM after the destruction of the Scrollbar element.
Maybe there's a better way to do it, but this restores functionality in IE10/11.
Last but not least, SCREW IE!