mmlicense: do not check against "requiredLicense" field #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new node is added for the first time to GPFS (without specifying a license on mmaddnode), the Host probably gets assigned the "client" license by default.
Now if you want to designate the Host as a server afterwards, this check would prevent you to do so, since by default the "requiredLicense" is set to "client".
This check isn't really needed anyway, because I assume one can just treat the "requiredLicense" field in mmlslicense as a "hint". The only thing that matters is the designatedLicense.
Additionally, GPFS will somehow anyway rewrite this internally at some point. Recently added a new node and designated it as "server". mmslicense shows "client" for "requiredLicense" and "server" for "designatedLicense" as expected. Some time later, mmlslicense showed "server" as "requiredLicense", and "fpo-server" for "designatedLicense".
/cc @wookietreiber