Added some feature requests #7
Conversation
Hellowlol
force-pushed
the
better_plx
branch
from
625d357
to
88e744e
Compare
| else: | ||
| str_type = basestring | ||
| byte_types = bytes | ||
| chr_ = lambda ch: ch | ||
| int_types = (int, long) |
| @@ -0,0 +1,444 @@ | |||
| from os.path import join, isdir, getsize, normpath, basename, getsize | |||
There was a problem hiding this comment.
A new file - hard to see was have changed, and what is new.
Classic approach is to make several braches (based on one another is they are connected) with gradual improvements introduction.
|
|
||
| _filepath = None | ||
|
|
||
| def __init__(self, |
There was a problem hiding this comment.
To many params for the initializer.
There was a problem hiding this comment.
Id still like to keep the "settings" and remove
webseeds=None,
httpseeds=None,
private=None,
announce_list=None,
comment=None,
creation_date=None,
created_by=None
thoughts?
There was a problem hiding this comment.
Common approach is to encapsulate settings in some settings object, and pass that object, yet, here I hardy can see any reasons for a separate object, since most of settings do belong solely to size calculation.
|
|
||
| return target_files_, total_size | ||
|
|
||
| def _calc_size(self, size): |
There was a problem hiding this comment.
Size calculation is discussed in #5
There was a problem hiding this comment.
I need to keep what we have now except from the blocksize ill change that to 32kb and add hardcoded limits. torrentool will use this by default unless some of the options is set.
| return self._set_announce_urls(val) | ||
|
|
||
| @property | ||
| def httpseed(self): |
| return 'magnet:?xt=urn:btih:' + self.info_hash | ||
|
|
||
| @property | ||
| def webseed(self): |
So this is most of the feature requests I have listed in #5
Is currently missing:
Dunno if i want to add that anyway.
I have fixed all tests that was broke on windows but i havnt tried it on linux, hence the pr so travis can test it.
It still needs some clean up so i use the same docstring and comments etc, adding a test for the cli and fixing cli for windows. Im not sure how to fix it. I havnt released anything on pypi but i assume we are missing a entry point for the cli. And what ever comments you might have
I dont except the pr to be merged, but let me know what you think.
Coveralls drops since it tests the pypi package now not the pr.