-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added non-zero exit code to run_bots if there is no bots to actually run #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, renamed `test_bots` to `test_bot_telegram` and make it a conditional test, based on `python-telegram-bot` module installed
Pull Request Test Coverage Report for Build 1800466733
💛 - Coveralls |
idlesign
requested changes
Jan 31, 2022
@idlesign I think this one is done. Please review it again. I've added a bunch of tests for new logic:
PS: Python 3.6 failing because of dependency shift. I'll prepare basic 'housekeeping' PR - shifting dates to 2022, removing 3.6 support etc.. |
Merged
Thank you. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice addition to #76
BotRegistrationFailed
if there are dependencies missing.run_bots
now exits with code 1 if were were no actual bots to run. this waysystemd
(orsupervisord
) status will show whether there is something wrong with bots on the startrenamedtest_bots
totest_bot_telegram
and made it conditional on the required package. this helps to pass tests on build servers without installing additional dependencies.(duplicate of #77, as for some reason it didn't pull latest commit)