Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "data-exit" to HTML loader #21

Closed
wants to merge 1 commit into from

Conversation

omigeot
Copy link

@omigeot omigeot commented Jan 20, 2014

As simple as it sounds : allows to define an exit function from the HTML code.

@idmillington
Copy link
Owner

Can you say why you're doing this. It is never being called in the code. So as it stands it might be something better for your fork, for your projects, rather than in the main repo. But I'm happy to be corrected, if there's a use-case here that might be general.

@omigeot
Copy link
Author

omigeot commented Jan 21, 2014

Well, I'm not sure it's the best way to do this, but I do try to keep all my situations in HTML form - I'd rather add some JavaScript to an HTML sit than define it completely in JS. So I do agree something more generic would be better (some way to declare a JS "constructor" to an HTML sit?), but that was off my league.

Ian Millington notifications@github.com a écrit :

Can you say why you're doing this. It is never being called in the
code. So as it stands it might be something better for your fork, for
your projects, rather than in the main repo. But I'm happy to be
corrected, if there's a use-case here that might be general.


Reply to this email directly or view it on GitHub:
#21 (comment)

Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.

@idmillington
Copy link
Owner

I'm going to close this pull request, because as it stands it is seems quite specific to your project. But I'm happy to think of other alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants