Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 0.9.9 #2

Closed
cweiske opened this Issue May 30, 2017 · 21 comments

Comments

Projects
None yet
6 participants
@cweiske
Copy link

cweiske commented May 30, 2017

https://hub.docker.com/r/library/known/tags/ still has 0.9.2 as most up-to-date version. Please support 0.9.9 (https://groups.google.com/forum/#!topic/known-dev/UXPHVXBmshQ).

@pierreozoux

This comment has been minimized.

Copy link
Collaborator

pierreozoux commented May 30, 2017

@benwerd could you add: https://github.com/docker-library-bot to the collaborators, then the process would be automatised.
Thanks!

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Nov 8, 2017

Looks like this was done in 676e8a4

@mapkyca mapkyca closed this Nov 8, 2017

@edrex

This comment has been minimized.

Copy link

edrex commented Jan 27, 2018

A new image built from the dockerfile still needs to uploaded to the registry: https://hub.docker.com/_/known/

+1 for automation :D

@edrex edrex referenced this issue Jan 27, 2018

Open

rebuild #1

@edrex

This comment has been minimized.

Copy link

edrex commented Jan 27, 2018

It seems like something is wrong with the build bot config. When I click the "Dockerfile" link next to "latest" on https://hub.docker.com/r/library/known/, it points to an old ref from 2016. The bot is building new images, but they seem to be pinned to that ref. IDK where in the various @docker-library metadata repos this ref is set. @pierreozoux any ideas?

@edrex

This comment has been minimized.

Copy link

edrex commented Jan 27, 2018

@pierreozoux pierreozoux reopened this Jan 27, 2018

@pierreozoux

This comment has been minimized.

Copy link
Collaborator

pierreozoux commented Jan 27, 2018

@benwerd or @mapkyca could you add: https://github.com/docker-library-bot to the collaborators, then the process would be automatised.
Thanks!

@edrex

This comment has been minimized.

Copy link

edrex commented Jan 31, 2018

For now I've forked this repo and set up an auto builder for my own use. https://hub.docker.com/r/pdxhub/known/

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Feb 10, 2018

@pierreozoux ... you mean to the Known-Docker project?

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Feb 10, 2018

... don't we just need to set up the integration..? https://docs.docker.com/docker-hub/builds/#understand-the-build-process ... or am I misunderstanding you :) (little troubled by giving third party accounts repo access, bot or no... seems like a bad way of automating something...)

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Feb 10, 2018

I think we just need to activate the docker hub service on the github side, in which case I'll need @benwerd to do it as he has the docker account it needs to go under.

I'll give him a ping...

@pierreozoux

This comment has been minimized.

Copy link
Collaborator

pierreozoux commented Feb 12, 2018

Sorry that it was not clear.
It is the automation process for official images.
(for regular images, yes, then you use the docker automated builds)

For the official images, you give access to a bot that can commit on this repo.
(I think it is a Jenkins repo)

It then runs once a day I think to run the update.sh script and figure out if there is a new version.
If there is, then it updates the Dockerfile.
And at the end, it generates the stackbrew library that is used to tag the official images.

So it is really cool, as the full process is automated. You see what I mean now?
If you need details, let me know.

@pierreozoux

This comment has been minimized.

Copy link
Collaborator

pierreozoux commented May 24, 2018

@mapkyca any news on that please?

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented May 25, 2018

I've given the bot read access to the repo, currently awaiting a response... not sure how long that will take...

@rikmendes

This comment has been minimized.

Copy link

rikmendes commented May 31, 2018

any news on this ?

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented May 31, 2018

I added the bot as a contributor, I'm not sure what happens next..

@pierreozoux

This comment has been minimized.

Copy link
Collaborator

pierreozoux commented Jun 6, 2018

The bot needs write access.
@J0WI could you help us on that please?

@J0WI

This comment has been minimized.

Copy link
Contributor

J0WI commented Jun 6, 2018

@J0WI could you help us on that please?

I'm not sure how?

@J0WI

This comment has been minimized.

Copy link
Contributor

J0WI commented Jun 6, 2018

I just had a look on the Dockerfile and it's currently broken. I would highly recommend to add a CI to the repo that you are aware of any failures.
A PR to fix the build is right around the corner.

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Jun 7, 2018

I've enabled write access.

@J0WI

This comment has been minimized.

Copy link
Contributor

J0WI commented Jun 7, 2018

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Feb 6, 2019

Assuming this is fixed now, closing

@mapkyca mapkyca closed this Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.