Fix up for modern known #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lorra Lorra files changed. Going to kick this over to @benwerd as he has assets which currently use S3 |
Lewiscowles1986
force-pushed
the
master
branch
from
ec7ddc1
to
3c88e71
Compare
Lewiscowles1986
force-pushed
the
master
branch
from
3c88e71
to
efb8c2e
Compare
|
I've updated again to follow conventions noted from @mapkyca https://github.com/mapkyca/known-ipfs for known plugins using composer (AFAIK won't be usable until merged, then registered with packagist) |
|
You rock, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary place to preview https://lewiscowles-known.herokuapp.com/2020/known-on-heroku-with-s3-support-in-2020
Fixes #1
Fixes #6
Fixes #7