Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence on Bootstrap #2617

Open
benwerd opened this issue Dec 5, 2019 · 9 comments
Open

Remove dependence on Bootstrap #2617

benwerd opened this issue Dec 5, 2019 · 9 comments
Projects

Comments

@benwerd
Copy link
Member

benwerd commented Dec 5, 2019

No official Known template should use Bootstrap on any level. Instead, we should use CSS grids and a simple, sensible base CSS stylesheet.

@benwerd benwerd created this issue from a note in Roadmap (1.5) Dec 5, 2019
@mapkyca
Copy link
Member

mapkyca commented Dec 5, 2019

I'd also like to remove the dependence on jquery

@benwerd
Copy link
Member Author

benwerd commented Dec 5, 2019

@mapkyca +1 - adding that to the roadmap too

@benwerd
Copy link
Member Author

benwerd commented Dec 5, 2019

See #2622

@johanbove
Copy link
Contributor

Even-though I agree with removing Bootstrap and jQuery dependencies, I would still advocate in keeping a CSS system, so all themes and core templates speak the same "CSS language". Would you consider TailWindCSS? https://tailwindcss.com/

@mapkyca
Copy link
Member

mapkyca commented Dec 6, 2019

We'll use sass, and whatever framework makes sense to give us a leg up.

I have a strong view that we actually make the front end skin a separate repo, that way the dependency management between core and plugins can be offloaded to composer.

Themes would build against a specific front end skin, meaning we can run multiple skins concurrently without breaking things for people. Gives people a lot more freedom to innovate.

@mapkyca
Copy link
Member

mapkyca commented Dec 7, 2019

I will also add that, where practical, we should move templating over to twig at this time. It's mature, widely used, more secure, and cross platform (so we could use the same template tools for e.g. react)

@benwerd
Copy link
Member Author

benwerd commented Dec 7, 2019

I’ll do some reading on Twig and React. It wasn’t in a place where expressive development was possible with it when I started work on Known, but I’d love it if it had evolved to work well with modern development practices. The thing I’m looking for is cascading templates: the ability to supersede just the templates you need to in order to create a new theme. Otherwise we have a ton of duplicated code in each new theme, which is impractical and messy (and potentially, in the worst case, a security issue).

@mapkyca
Copy link
Member

mapkyca commented Dec 7, 2019

Yep yep. Totally possible right now with the hybrid template class right now in known (if there's a twig template, it'll be used, just like a standard bonita template).

It's a fairly simplistic approach, and there's lots that twig can do that we might not be able to use with this approach (like twig native inserts and overrides), but as I look into it more we can do more.

My point is that we should be consistent with templating and not reinvent the wheel - twig is mature and supported both in javascript and for classic back end generated dom.

@ipranjal
Copy link
Contributor

+1 for twig I am up for that

This was referenced Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Roadmap
  
July 1, 2020
Development

No branches or pull requests

4 participants