Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revoke VID #233

Merged
merged 6 commits into from
Sep 27, 2022
Merged

Revoke VID #233

merged 6 commits into from
Sep 27, 2022

Conversation

danicaerediano
Copy link
Collaborator

@danicaerediano danicaerediano commented Sep 27, 2022 •
edited
Loading

Address comment: #210 (comment)

  • single revoke: deleted VID from store and redirect to homepage
  • bulk revoke:deleted all selected VIDs from store and refreshed list
  • fix revoke successful toast message

pmigueld
pmigueld approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@pmigueld pmigueld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this for now but try to use the state machines as much as possible for managaing business logic and states. We can refactor this later if we have time.

@pmigueld pmigueld merged commit f100904 into develop Sep 27, 2022
@pmigueld pmigueld deleted the fix/revoke-message branch September 27, 2022 07:04
This was referenced Oct 17, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmigueld pmigueld pmigueld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danicaerediano @pmigueld @danicaMat