New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a white symbol for external links #258

Merged

Idrinth merged 1 commit into master from issue-238-svg-icon

Feb 4, 2024

Member

Idrinth commented Feb 4, 2024 •

edited

Loading

The Pull Request is ready

fixes SVG icon for external links barely visible in dark mode #238
all actions are passing
only fixes a single issue

Website

mobile view is useable
desktop view is useable
no a-tags are used direktly (NavLink, MailLink, ExternalLink instead)
all new texts are added to the translation files (at least the english one)
tests have been added (if required)
shared code has been extracted in a different file


          add a white symbol for external links

Idrinth marked this pull request as ready for review

February 4, 2024 02:55

Idrinth merged commit d6a8a5e into master

4 checks passed

Idrinth deleted the issue-238-svg-icon branch

February 4, 2024 02:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment