Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL 'last change' time-stamp should be taken from start of reload #23

Closed
edwinb opened this issue May 20, 2020 · 0 comments · Fixed by #1535
Closed

REPL 'last change' time-stamp should be taken from start of reload #23

edwinb opened this issue May 20, 2020 · 0 comments · Fixed by #1535

Comments

@edwinb
Copy link
Collaborator

edwinb commented May 20, 2020

Issue by ohad
Friday Oct 18, 2019 at 12:17 GMT
Originally opened as edwinb/Idris2-boot#127


Steps to Reproduce

Take a file that takes idris2 a while to type-check, say Foo.idr.
While idris2 is type-checking, make a change in the file and save before idris2 finishes.
Reload the file.

Expected Behavior

Main> :r
1/1 Building Main (Foo.idr)
Main> 

Observed Behavior

Main> :r
Main> 

I think this is because the timestamp on the last change to this file is taken after type-checking finishes, and it should be taken before type-checking starts.

melted pushed a commit to melted/Idris2 that referenced this issue Jun 1, 2020
melted pushed a commit to melted/Idris2 that referenced this issue Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant