librbd: block_name_prefix is not created randomly

fixes: http://tracker.ceph.com/issues/24634 Signed-off-by: hyun ha hyun.ha@navercorp.com
idryomov · Sep 11, 2018 · be83736 · be83736
1 parent 86f3bcf
commit be83736
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/librbd/Utils.cc b/src/librbd/Utils.cc
@@ -11,6 +11,7 @@
 #include "common/dout.h"
 #include "librbd/ImageCtx.h"
 #include "librbd/Features.h"
+#include <random>
 
 #define dout_subsys ceph_subsys_rbd
 #undef dout_prefix
@@ -51,7 +52,9 @@ std::string generate_image_id(librados::IoCtx &ioctx) {
   librados::Rados rados(ioctx);
 
   uint64_t bid = rados.get_instance_id();
-  uint32_t extra = rand() % 0xFFFFFFFF;
+  std::mt19937 generator{std::random_device{}()};
+  std::uniform_int_distribution<uint32_t> distribution{0, 0xFFFFFFFF};
+  uint32_t extra = distribution(generator);
 
   ostringstream bid_ss;
   bid_ss << std::hex << bid << std::hex << extra;