Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated and confusing code from CsvGridSource #304

Closed
sebastian-peter opened this issue Aug 4, 2022 · 0 comments · Fixed by #305
Closed

Remove deprecated and confusing code from CsvGridSource #304

sebastian-peter opened this issue Aug 4, 2022 · 0 comments · Fixed by #305
Assignees
@sebastian-peter
Labels
code quality Code readability or efficiency is improved dependencies Pull requests that update a dependency file

Comments

@sebastian-peter
Copy link
Member

This also fixes errors resulting from snapshot updates of PSDM
@sebastian-peter sebastian-peter added dependencies Pull requests that update a dependency file code quality Code readability or efficiency is improved labels Aug 4, 2022
@sebastian-peter sebastian-peter self-assigned this Aug 4, 2022
@sebastian-peter sebastian-peter mentioned this issue Aug 4, 2022
Merged
danielfeismann added a commit that referenced this issue Aug 4, 2022
@danielfeismann
Merge pull request #305 from ie3-institute/sp/#304-cleanup-CsvGridSource
b450c52 
Simplifying CsvGridSource and providing TestGridFactory
sebastian-peter added a commit that referenced this issue Aug 4, 2022
@sebastian-peter
Merge branch 'sp/#304-cleanup-CsvGridSource' into sp/#204-EmAgent
0aa75f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastian-peter sebastian-peter

Labels
code quality Code readability or efficiency is improved dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplifying CsvGridSource and providing TestGridFactory ie3-institute/simona
1 participant
@sebastian-peter