Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplifying CsvGridSource and providing TestGridFactory #305

Merged
merged 4 commits into from
Aug 4, 2022
Merged

Simplifying CsvGridSource and providing TestGridFactory #305

merged 4 commits into from
Aug 4, 2022

Conversation

sebastian-peter
Copy link
Member

Resolves #304

@sebastian-peter sebastian-peter added dependencies Pull requests that update a dependency file code quality Code readability or efficiency is improved labels Aug 4, 2022
@sebastian-peter sebastian-peter marked this pull request as ready for review August 4, 2022 10:43
@codecov
Copy link

codecov bot commented Aug 4, 2022 •
edited
Loading

Codecov Report

Merging #305 (629f7aa) into dev (ef2af1d) will increase coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #305      +/-   ##
==========================================
+ Coverage   79.93%   80.22%   +0.29%     
==========================================
  Files         161      161              
  Lines        5940     5917      -23     
  Branches       81       81              
==========================================
- Hits         4748     4747       -1     
+ Misses       1192     1170      -22
Impacted Files Coverage Δ
...in/scala/edu/ie3/simona/io/grid/GridProvider.scala 60.00% <0.00%> (ø)
...n/scala/edu/ie3/simona/io/grid/CsvGridSource.scala 90.90% <0.00%> (+58.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sebastian-peter sebastian-peter self-assigned this Aug 4, 2022
@sebastian-peter sebastian-peter marked this pull request as draft August 4, 2022 10:53
@sebastian-peter sebastian-peter marked this pull request as ready for review August 4, 2022 10:56
danielfeismann
danielfeismann approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for the quick error correction done here.

@danielfeismann danielfeismann merged commit b450c52 into dev Aug 4, 2022
@danielfeismann danielfeismann deleted the sp/#304-cleanup-CsvGridSource branch August 4, 2022 11:52
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann approved these changes

@t-ober t-ober Awaiting requested review from t-ober

Assignees

@sebastian-peter sebastian-peter

Labels
code quality Code readability or efficiency is improved dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Remove deprecated and confusing code from CsvGridSource
2 participants
@sebastian-peter @danielfeismann