Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix controllingEms within buildParticipantToActorRef #842

Merged
merged 8 commits into from
Jul 5, 2024
Merged

Fix controllingEms within buildParticipantToActorRef #842

merged 8 commits into from
Jul 5, 2024

Conversation

danielfeismann
Copy link
Member

resolves #841

@danielfeismann danielfeismann added the bug Something isn't working label Jul 2, 2024
@danielfeismann danielfeismann self-assigned this Jul 2, 2024
@danielfeismann danielfeismann marked this pull request as ready for review July 3, 2024 08:54
@danielfeismann danielfeismann mentioned this pull request Jul 3, 2024
Merged
sebastian-peter
sebastian-peter requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions from my side to make the code neater and maybe a bit safer. Let me know what you think

src/main/scala/edu/ie3/simona/agent/grid/GridAgentController.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/agent/grid/GridAgentController.scala Outdated Show resolved Hide resolved
sebastian-peter
sebastian-peter approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@sebastian-peter sebastian-peter merged commit a7eb902 into dev Jul 5, 2024
4 checks passed
@sebastian-peter sebastian-peter deleted the df/#841_fix_em branch July 5, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

Assignees

@danielfeismann danielfeismann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix controllingEms within buildParticipantToActorRef
2 participants
@danielfeismann @sebastian-peter