Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YANG Doctor Review #3

Merged
merged 18 commits into from
May 8, 2020
Merged

YANG Doctor Review #3

merged 18 commits into from
May 8, 2020

Conversation

haomianzheng
Copy link
Member

this pull request is to fix the comments proposed in https://mailarchive.ietf.org/arch/msg/ccamp/vpIjwy2HokZI74pKkIBrr0fziIw, and its followup discussion.

this pull request is to fix the comments proposed in https://mailarchive.ietf.org/arch/msg/ccamp/vpIjwy2HokZI74pKkIBrr0fziIw, and its followup discussion
Copy link
Contributor

@agva123 agva123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layer0-node-type - change to l0-node-type to make it consistent with the rest of the l0 abbreviation

@haomianzheng
Copy link
Member Author

layer0-node-type - change to l0-node-type to make it consistent with the rest of the l0 abbreviation

This is raised during the feedback to YANG doctor, and will be revised after consensus.
Following changes would be needed on,
layer0-node-type -> l0-node-type
layer0-grid-type -> l0-grid-type
layer0-bandwidth-type -> l0-bandwidth-type
layer0-label-range-info -> l0-label-range-info

Add more reference, per request in #4.
ietf-layer0-types.yang Outdated Show resolved Hide resolved
ietf-layer0-types.yang Outdated Show resolved Hide resolved
ietf-layer0-types.yang Outdated Show resolved Hide resolved
ietf-layer0-types.yang Outdated Show resolved Hide resolved
ietf-layer0-types.yang Outdated Show resolved Hide resolved
ietf-layer0-types.yang Outdated Show resolved Hide resolved
haomianzheng and others added 3 commits April 8, 2020 09:59
Co-Authored-By: italobusi <italo.busi@huawei.com>
Co-Authored-By: italobusi <italo.busi@huawei.com>
This update solves the open issue #6 and #9

This update also solves the  comments raised on the ccamp mailing list: 
https://mailarchive.ietf.org/arch/msg/ccamp/qp4YJCYKx-pNaajY31XEis4nFS0/
@italobusi
Copy link
Member

italobusi commented Apr 15, 2020

For alignment with dwdm-n and flexi-n, it would be better to introduce the channel spacing also for the cwdm-n:

Wavelength (nm) = 1471 + N x 20 ";

Proposed changes:

        Wavelength (nm) = 1471 + N x channel-spacing (measured in nm),
      where 1471 nm is the ITU-T 'anchor wavelength'
        for transmission over the C band; and
      where 'channel-spacing' is defined by the cwdm-ch-spc-type.";

Copy link
Member

@italobusi italobusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just few editorial comments aimed at improving the readability of the code

ietf-layer0-types.yang Outdated Show resolved Hide resolved
ietf-layer0-types.yang Outdated Show resolved Hide resolved
ietf-layer0-types.yang Outdated Show resolved Hide resolved
ietf-layer0-types.yang Outdated Show resolved Hide resolved
ietf-layer0-types.yang Outdated Show resolved Hide resolved
ietf-layer0-types.yang Outdated Show resolved Hide resolved
ietf-layer0-types.yang Show resolved Hide resolved
ietf-layer0-types.yang Outdated Show resolved Hide resolved
ietf-layer0-types.yang Outdated Show resolved Hide resolved
haomianzheng and others added 7 commits April 20, 2020 15:49
Co-Authored-By: italobusi <italo.busi@huawei.com>
Co-Authored-By: italobusi <italo.busi@huawei.com>
Co-Authored-By: italobusi <italo.busi@huawei.com>
Co-Authored-By: italobusi <italo.busi@huawei.com>
Co-Authored-By: italobusi <italo.busi@huawei.com>
Co-Authored-By: italobusi <italo.busi@huawei.com>
ietf-layer0-types.yang Outdated Show resolved Hide resolved
ietf-layer0-types.yang Outdated Show resolved Hide resolved
Copy link
Member

@italobusi italobusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the revision date

ietf-layer0-types.yang Outdated Show resolved Hide resolved
Co-Authored-By: italobusi <italo.busi@huawei.com>
@haomianzheng
Copy link
Member Author

layer0-node-type - change to l0-node-type to make it consistent with the rest of the l0 abbreviation

This has been done in the latest commit.

ietf-layer0-types.yang Show resolved Hide resolved
ietf-layer0-types.yang Outdated Show resolved Hide resolved
@haomianzheng haomianzheng merged commit 368a8d7 into master May 8, 2020
italobusi added a commit that referenced this pull request May 8, 2020
Proposed editorial changes
Redefined flexi-m as uint16
Addressing Sergio's comments to PR #3:
- #3 (comment)
- #3 (comment)
italobusi added a commit that referenced this pull request May 8, 2020
Proposed editorial changes
Redefined flexi-m as uint16
Addressing Sergio's comments to PR #3:
- #3 (comment)
- #3 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants