-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YANG Doctor Review #3
Conversation
this pull request is to fix the comments proposed in https://mailarchive.ietf.org/arch/msg/ccamp/vpIjwy2HokZI74pKkIBrr0fziIw, and its followup discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
layer0-node-type - change to l0-node-type to make it consistent with the rest of the l0 abbreviation
This is raised during the feedback to YANG doctor, and will be revised after consensus. |
Add more reference, per request in #4.
Co-Authored-By: italobusi <italo.busi@huawei.com>
Co-Authored-By: italobusi <italo.busi@huawei.com>
This update solves the open issue #6 and #9 This update also solves the comments raised on the ccamp mailing list: https://mailarchive.ietf.org/arch/msg/ccamp/qp4YJCYKx-pNaajY31XEis4nFS0/
For alignment with dwdm-n and flexi-n, it would be better to introduce the channel spacing also for the cwdm-n:
Proposed changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just few editorial comments aimed at improving the readability of the code
Co-Authored-By: italobusi <italo.busi@huawei.com>
Co-Authored-By: italobusi <italo.busi@huawei.com>
Co-Authored-By: italobusi <italo.busi@huawei.com>
Co-Authored-By: italobusi <italo.busi@huawei.com>
Co-Authored-By: italobusi <italo.busi@huawei.com>
Co-Authored-By: italobusi <italo.busi@huawei.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the revision date
Co-Authored-By: italobusi <italo.busi@huawei.com>
This has been done in the latest commit. |
Proposed editorial changes Redefined flexi-m as uint16 Addressing Sergio's comments to PR #3: - #3 (comment) - #3 (comment)
Proposed editorial changes Redefined flexi-m as uint16 Addressing Sergio's comments to PR #3: - #3 (comment) - #3 (comment)
this pull request is to fix the comments proposed in https://mailarchive.ietf.org/arch/msg/ccamp/vpIjwy2HokZI74pKkIBrr0fziIw, and its followup discussion.