Tom Petch all comments

[sergiobelotti]

Please see the email with Tom comments
https://mailarchive.ietf.org/arch/msg/ccamp/RIo9U_DQpo4CFFwgOyhN4YV1a88/

Prompted by the YANG doctor review I had another look at this and have some additional comments

References - lots needed in the YANG; import MUST have them and the data should in many cases. The Informational References in the I-D look good but need adding to the YANG.

• Add References for imported modules #146

s.1.3 layer 0 prefix is incorrect - the module has it right.

Fixed

Description I would like more especially where it is '..'

• Tom Petch comments : missing description in YANG  #141

Look too at the prefix of the referenced modules - tet, nw ne - good choices; optical-imp-topo is too long IMHO; IANA has a list of modules and prefix most of which look good. You might want to share some initial letters with other CCAMP modules (WDM?).

• To be discussed - Agreed . YANG and TEXT in the draft
• Agreed to use "oit" as prefix.

There are some quirky spellings but I leave those a last call review

Figure 1 title would be better as RFC YYYY ....
with a note to the RFC Editor

• To be fixed- TEXT in the draft

There are a number of TBA TBD yet to be fleshed out

• To be fixed TEXT in the draft

Compared to earlier revisions, many of the 'augment' 'when' have been amended to relative form but not all; I am sure you know the impact of absolute form but is this intended?

• Absolute path in grouping power-param #155

In the descriptions I think '1' should be 'one'

• In the descriptions '1' should be 'one' #147

           leaf nominal-power-spectral-density{
               type decimal64 {
                   fraction-digits 16;
             units W/Hz ;
             description
                 Typical value : 3.9 E-14, resolution 0.1nW/MHz"; That typical value like any value will look ugly with 16 fraction digits - I assume that this does not use floating point.

This is a common issue with uint64 and decimal64. The bandwidth-ieee-float32 defined in RFC8294 would be even more ugly.

Security Considerations is out of date; current one drags in HTTPS, TLS, RESTCON.

• Update Security Considerations #145

Tom Petch

[sergiobelotti]

Look too at the prefix of the referenced modules - tet, nw ne - good choices; optical-imp-topo is too long IMHO; IANA has a list of modules and prefix most of which look good. You might want to share some initial letters with other CCAMP modules (WDM?).

To be discussed

Call on September 12:
one proposal could be "oit".