I-D text update resolving #150, #151, and #157 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This I-D update resolves: - #150 - #151 + pure editorial updates/corrections Co-Authored-By: Esther Le Rouzic <EstherLerouzic@users.noreply.github.com> Co-Authored-By: Gabriele Galimberti <ggalimbe56@gmail.com> Co-Authored-By: sergio belotti <sergio.belotti@nokia.com> Co-Authored-By: italobusi <12461741+italobusi@users.noreply.github.com>
dieterbeller
requested review from
EstherLerouzic,
italobusi,
sergiobelotti and
ggalimba56
italobusi
approved these changes
Sep 25, 2023
sergiobelotti
approved these changes
Sep 25, 2023
This I-D update addesses: - #144 : some comments resolved - #153 : new DGE sub-section added - #154 : latest YANG code and tree view incorporated + pure editorial updates/corrections Co-Authored-By: Esther Le Rouzic <EstherLerouzic@users.noreply.github.com> Co-Authored-By: sergio belotti <sergio.belotti@nokia.com> Co-Authored-By: italobusi <12461741+italobusi@users.noreply.github.com> Co-Authored-By: Gabriele Galimberti <ggalimbe56@gmail.com>
sergiobelotti
approved these changes
Oct 21, 2023
italobusi
approved these changes
Oct 22, 2023
This I-D update resolves: - #157 : Examples of how vendors can define their operational modes. + pure editorial updates/corrections Co-Authored-By: Esther Le Rouzic <EstherLerouzic@users.noreply.github.com> Co-Authored-By: sergio belotti <sergio.belotti@nokia.com> Co-Authored-By: italobusi <12461741+italobusi@users.noreply.github.com> Co-Authored-By: Gabriele Galimberti <ggalimbe56@gmail.com>
ggalimba56
approved these changes
Oct 23, 2023
dieterbeller
changed the title
| @@ -2886,7 +2941,7 @@ module: ietf-optical-impairment-topology | |||
| | +--ro otsi-ref* [] | |||
| | | +--ro otsi-carrier-ref? leafref | |||
| | | +--ro e2e-mc-path-ref* leafref | |||
| | +--ro delta-power? l0-types:power-in-dbm-or-null | |||
| | +--ro delta-power? l0-types:gain-in-db-or-null | |||
There was a problem hiding this comment.
delta-power contains a ratio in dB. one may call it gain, however gain is only positive, where delta_p could be negative. so the type should be changed
| | +--ro flexi-m? | ||
| | | l0-types:flexi-m | ||
| | +--ro delta-power? | ||
| | l0-types:gain-in-db-or-\ |
| @@ -3823,7 +3937,7 @@ module ietf-optical-impairment-topology { | |||
| } | |||
| } | |||
| leaf delta-power { | |||
| type l0-types:power-in-dbm-or-null; | |||
| type l0-types:gain-in-db-or-null; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This I-D update resolves: