Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optical power info on amps in/out ports #85

Closed
EstherLerouzic opened this issue Jul 27, 2021 · 5 comments · Fixed by #104
Closed

Add optical power info on amps in/out ports #85

EstherLerouzic opened this issue Jul 27, 2021 · 5 comments · Fixed by #104
Assignees
Labels
agreed Resolution has been agreed: need for a PR to be merged before closing the issue enhancement New feature or request IETF-113 Issue to be closed with PR for IETF-113 YANG proposal exists

Comments

@EstherLerouzic
Copy link
Collaborator

This was raised on issue #45, as a use case for ports info. But finally we agreed to not have ports, but we did not follow up on the need for optical power (did not find an issue on that, so I start this one).

Optical power is especially needed to recompute / check consistency of span (fiber+concentrated loss) loss value, with respect to loss/gain information on elements.

@sergiobelotti sergiobelotti added the enhancement New feature or request label Nov 2, 2021
@sergiobelotti
Copy link
Collaborator

sergiobelotti commented Dec 6, 2021

see the tree proposal at #46 (comment)

in the proposal there is output-power new attribute , and the description in YANG could be: " it represent total output power measured in the range specified by fmin and fmax .

@egriseri
Copy link
Collaborator

Hi @EstherLerouzic, are you proposing a mandatory or optional parameter?

@EstherLerouzic
Copy link
Collaborator Author

Yes I would prefer it mandatory

@sergiobelotti
Copy link
Collaborator

Hi @EstherLerouzic, are you proposing a mandatory or optional parameter?

We discussed that during the meeting on 14 December and we say that the attribute should be mandatory.
Italo proposed to call the attribute "total-output-power".

@sergiobelotti
Copy link
Collaborator

We need:

  • to add attribute "total-output-power" in the container "operational" in the grouping "amplifier-params"
  • description : "It represent total output power measured in the range specified by fmin and fmax . Optical power is especially needed to re-compute / check consistency of span (fiber+ concentrated loss) loss value, with respect to loss/gain information on elements."

@sergiobelotti sergiobelotti added the IETF-113 Issue to be closed with PR for IETF-113 label Jan 31, 2022
@sergiobelotti sergiobelotti added the agreed Resolution has been agreed: need for a PR to be merged before closing the issue label Feb 1, 2022
italobusi added a commit that referenced this issue Mar 2, 2022
Fix #85
- added total-output-power to the amplifier-params grouping
Fix #99 :
- Updated types with union with type empty when applicable
Fix #100
- via PR ietf-ccamp-wg/ietf-ccamp-layer0-types-ext-RFC9093-bis#36
Fix #102 :
- added raman-direction to the amplifier-params grouping
- added raman-pump list to the amplifier-params grouping

Co-Authored-By: sergio belotti <sergio.belotti@nokia.com>
italobusi added a commit that referenced this issue Mar 7, 2022
* Updated YANG model for IETF 113

Fix #85
- added total-output-power to the amplifier-params grouping

Fix #99 :
- Updated types with union with type empty when applicable
- Added description about the empty types

Fix #100
- via PR ietf-ccamp-wg/ietf-ccamp-layer0-types-ext-RFC9093-bis#36

Fix #102 :
- added raman-direction to the amplifier-params grouping
- added raman-pump list to the amplifier-params grouping

Fix #103:
- YANG aligned with PR ietf-ccamp-wg/ietf-ccamp-layer0-types-ext-RFC9093-bis#36

Co-authored-by: sergio belotti <sergio.belotti@nokia.com>
Co-authored-by: Dieter Beller <Dieter.Beller@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agreed Resolution has been agreed: need for a PR to be merged before closing the issue enhancement New feature or request IETF-113 Issue to be closed with PR for IETF-113 YANG proposal exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants