-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Henk's review feedback for WGLC #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me, please rebase and mark as ready for review
draft-ietf-rats-endorsements.md
Outdated
manner. The state of an Attester also encompasses the combination of static and | ||
dynamic constitution (e.g., provisioned and deployed software, firmware, and | ||
components of execution environments (its "shape" or "composition"), typically in a hierarchical | ||
manner, i.e., a tree graph. The state of an Attester also encompasses the combination of static and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have never seen "tree graph". You could say "tree" or "connected and acyclic graph". My preference is for the former.
draft-ietf-rats-endorsements.md
Outdated
states, and an appraisal policy that controls how the two are compared. | ||
|
||
Each Attester in general has at least one Attesting Environment and one Target | ||
Environment (e.g., hardware, firmware, Operating System, etc.). Typically, each | ||
Attester has multiple Target Environments, each with their own set of claims (sometimes | ||
called a "claimset") representing their actual state. Additionally, the number of | ||
Target Environments is not limited. | ||
called a "claim sets") representing their actual-state. Additionally, the number of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the non-hyphenised version "actual state". Besides, the term should be made consistent across the whole document.
draft-ietf-rats-endorsements.md
Outdated
called a "claim sets") representing their actual-state. Additionally, the number of | ||
Target Environments and Attesting Environments that are components of an Attester are not limited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest removing the sentence "[A]dditionally, [...] not limited" as it doesn't add any value to the paragraph.
draft-ietf-rats-endorsements.md
Outdated
"Reference state" is a group of claimsets about the desired or undesired state of | ||
the Attester. Typically, each claim has a name (or other ID) and | ||
"Reference state" is a group of claim sets about the desired or undesired state of | ||
an Attester. Typically, each claim has a name (or key, label, or other ID) and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
added more words instead of removing words, but I think is this okay
removed redundant verbosity
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
a little bit late, but there are always little fires everywhere.