Consistant tc list in update #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcd500
force-pushed
the
consistant-tc-list-in-update
branch
from
90c247f
to
79b87d2
Compare
dthaler
requested changes
Jan 5, 2021
| @@ -1110,7 +1110,7 @@ update = [ | |||
| type: TEEP-TYPE-update, | |||
| options: { | |||
| ? token => uint, | |||
| ? tc-list => [ + SUIT_Component_Identifier ], | |||
There was a problem hiding this comment.
this should be SUIT_Component_Identifier, to match the type of unneeded-tc-list in the QueryResponse message. It would be ok to rename tc-list here (e.g., to unneeded-tc-list or delete-tc-list).
| @@ -527,7 +527,7 @@ update = [ | |||
| type: TEEP-TYPE-update, | |||
| options: { | |||
| ? token => uint, | |||
| ? tc-list => [ + bstr ], | |||
| ? tc-list => [ + tc-info ], | |||
There was a problem hiding this comment.
This was incorrect before (thanks for catching), but tc-info is not the correct type. See my next comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the type of tc-list to be array of tc-info among all teep messages.