-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/meeting/upcoming.ics is unstable #3097
Comments
@rjsparks@nostrum.com commented This appears to be only a reordering of the VTIMEZONE elements, but it is causing trouble for at least one person attempting to build a cache. |
@henrik@levkowetz.com commented In upcoming_ical(), the 'vtimezones' template variables is generated from a set complrehension (in order to list each timezone definition only once), but doing a "".join() on that set is not stable (and not expected to be stable). Fix coming. |
@henrik@levkowetz.com changed _comment0 which not transferred by tractive |
@henrik@levkowetz.com changed status from |
@henrik@levkowetz.com changed resolution from `` to |
@henrik@levkowetz.com commented Fixed in c4a28de: Tweaked the generation of .ics vtimezone entries to have a stable order in /meeting/upcoming.ics. Fixes issue #3097. |
resolution_fixed
type_defect
| by rjsparks@nostrum.comback-to-back fetches of upcoming.ics produce documents that (at least) should mean the same thing to a calendar but are very different bytewise. Events are returned in different orders perhaps.
We should check to see if other ics generation is affected similarly.
Issue migrated from trac:3097 at 2022-03-04 08:02:32 +0000
The text was updated successfully, but these errors were encountered: