Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback_email management command needs better exception handling #3356

Closed
ietf-svn-bot opened this issue Jul 19, 2021 · 9 comments
Closed

Comments

@ietf-svn-bot
Copy link

owner:jennifer@painless-security.com resolution_fixed type_defect | by rjsparks@nostrum.com


We have at least one instance of an email crashing the feedback_email command in a way that causes them to get a bounce from the mail system that looks like:

This is the mail system at host ietfa.amsl.com. I'm sorry to have to 
inform you that your message could not be delivered to one or more 
recipients. It's attached below. For further assistance, please send 
mail to postmaster. If you do so, please include this problem report. 
You can delete your own text from the attached returned message. The 
mail system <nomcom-recipients-21@ietfa.amsl.com>: Command died with 
status 1: "/a/www/ietf-datatracker/web/ietf/virtualenv-manage.py 
feedback_email --nomcom-year 2021". Command output: CommandError: 
'utf-8' codec can't decode byte 0xb7 in position 114: invalid start byte

This should not fail this way - if we can't recover enough to let the automated ingestion succeed it would be better to wrap the exception into something that gets sent (including the original message) to the nomcom chair.


Issue migrated from trac:3356 at 2022-03-04 09:08:46 +0000

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed status from new to accepted

@ietf-svn-bot
Copy link
Author

@jennifer@painless-security.com commented


On #3357, email to settings.ADMINS was requested. Should the admins be contacted for this one, either instead of or alongside the nomcom chair?

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


No - only the nomcom chair should get this one. These messages have confidential content that the admins should not see.

@ietf-svn-bot
Copy link
Author

@jennifer@painless-security.com changed status from accepted to assigned

@ietf-svn-bot
Copy link
Author

@jennifer@painless-security.com set owner to jennifer@painless-security.com

@ietf-svn-bot
Copy link
Author

@jennifer@painless-security.com changed status from assigned to closed

@ietf-svn-bot
Copy link
Author

@jennifer@painless-security.com set resolution to fixed

@ietf-svn-bot
Copy link
Author

@jennifer@painless-security.com commented


Fixed in 968b775:

Create management command base class that sends emails on exceptions. Fixes #3356 and #3357. Commit ready for merge.

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


Fixed in d9dc4f5:

Merged in 968b775 from jennifer@painless-security.com:
Create management command base class that sends emails on exceptions. Fixes #3356 and #3357.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant