Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

management commands that create draft- and group-virtual files create a big operational fail window. #3521

Closed
ietf-svn-bot opened this issue Jan 25, 2022 · 6 comments

Comments

@ietf-svn-bot
Copy link

resolution_fixed type_defect | by rjsparks@nostrum.com


Right now, the virtual table creating management commands open the virtual table directly for write, then do a bunch of computation to populate it.

When any management command is run, system checks are run, and if the files are empty the system checks error, causing the management command to exit.

(It may well be that system checks are run when a worker is started...)

Instead, the commands should build the new -virtual files in a tmp file and move it into place.


Issue migrated from trac:3521 at 2022-03-04 09:25:36 +0000

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed priority from medium to critical

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed status from new to accepted

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed status from accepted to closed

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com set resolution to fixed

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


Fixed in d6298ad:

Use tempfiles while rebuilding group and doc alias files. Fixes #3521. Commit ready for merge.

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


Fixed in 3fa90e7:

Merged in d6298ad from rjsparks@nostrum.com:
Use tempfiles while rebuilding group and doc alias files. Fixes #3521.

jennifer-richards pushed a commit to painless-security/datatracker that referenced this issue Mar 7, 2022
jennifer-richards pushed a commit to painless-security/datatracker that referenced this issue Mar 7, 2022
    Use tempfiles while rebuilding group and doc alias files. Fixes ietf-tools#3521.
 - Legacy-Id: 19958
Note: SVN reference [19949] has been migrated to Git commit d6298ad
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant