Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new calendar icon for .ics file download needs tooltip / title #3695

Closed
1 task done
kivinen opened this issue Mar 19, 2022 · 4 comments
Closed
1 task done

The new calendar icon for .ics file download needs tooltip / title #3695

kivinen opened this issue Mar 19, 2022 · 4 comments
Labels
accepted bs5 Bootstrap 5 facelift bug Something isn't working

Comments

@kivinen
Copy link
Contributor

kivinen commented Mar 19, 2022

What happened?

The new icon on the http://localhost:8000/wg/ipsecme/meetings/ page for downloading .ics file is so "abstract" that it needs tooltip to explain what it is. It looks like monitor with title bar on the top, but I think it is supposed to be some kind of calendar... The old icon was bit more understandable, but we should add a check that you can't use any kind icons without tooltip text that explains what it does.

For example on the page http://localhost:8000/meeting/113/session/ipsecme we do have multiple similar icons, but all of them (including the download calendar file icon) do have tooltips which explain what they do.

I was wondering can we make a test that goes through all the html templates we have and verify that any of them using any of the icons do actually also include tooltip?

What browser(s) are you seeing the problem on?

No response

Code of Conduct

  • I agree to follow the IETF's Code of Conduct
@kivinen kivinen added the bug Something isn't working label Mar 19, 2022
@larseggert
Copy link
Collaborator

Pick a different one from https://icons.getbootstrap.com/?

@kivinen
Copy link
Contributor Author

kivinen commented Mar 19, 2022 via email

@rjsparks
Copy link
Member

screenreaders probably do poorly with icons - tooltips are likely to help.
Tooltips are easy to do - is there any reason to avoid them?
(This is also a class of things that we can try to get professional help with)

@larseggert
Copy link
Collaborator

A tooltip is fine, just add a title attribute on the icon.

@rjsparks rjsparks added accepted bs5 Bootstrap 5 facelift labels Mar 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted bs5 Bootstrap 5 facelift bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants