Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate last call text should include the document set's abstracts #662

Closed
ietf-svn-bot opened this issue May 9, 2011 · 3 comments
Closed

Comments

@ietf-svn-bot
Copy link

owner:rjsparks@nostrum.com resolution_fixed type_enhancement | by rjsparks@nostrum.com


Per the IESGs intent to include Abstracts in last call announcements, the generate last call text function should include the abstracts by default.


Issue migrated from trac:662 at 2022-03-04 01:49:46 +0000

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed status from new to closed

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com set resolution to fixed

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


Fixed in 6484874:

  1. Restructured the position editing page to better integrate the defer button.
    Fixes bug Improve the layout of the edit-position form so that the actions that conplete the form are more intuitive #659

  2. Copied the jquery-1.5.1.min.js library into /static/js/lib (from /static/js)
    because that's where the main document template was looking for it. There have
    probably been several problems since the change that left this dangling that
    showed up as things not behaving, but not as errors. The one that clued me in
    was the discuss text-box not being hidden when the position wasn't DISCUSS.
    They should all behave better now.

  3. Added a django form validator to the discuss text field to not allow actions
    when the position is Discuss, but the discuss-text is empty.
    2 and 3 together fix bug Prevent the "discuss text not found" error #660

  4. Added logic to the undefer fuction to put the document back on the previous
    telechat (if that hasn't already passed). That is, date1 from telechat dates,
    and not date2.
    Fixes bug Undefer should move a document back to the telechat it was deferred from #661

  5. Changed the last_call_announcement generation function's template to include
    the abstracts from the document sets (which with modern usage means the abstract
    of the document) reflecting the IESGs decision of a few months back.
    Fixes bug Generate last call text should include the document set's abstracts #662

  6. Removed the old tracker link from the document's main page
    Fixes bug Remove the button that links to the old IESG tracker #663

_M .
M ietf/idrfc/views_ballot.py
M ietf/templates/idrfc/last_call_announcement.txt
M ietf/templates/idrfc/undefer_ballot.html
M ietf/templates/idrfc/doc_tab_document.html
M ietf/templates/idrfc/edit_position.html
_M ietf/utils/draft.py
_M static/media
A + static/js/lib/jquery-1.5.1.min.js

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant