This repository has been archived by the owner on Apr 24, 2020. It is now read-only.
Remove TLS-SNI-02 challenge type and associated refs. #390
Merged
cpu
merged 4 commits into
ietf-wg-acme:master
from
cpu:cpu-tls-sni-02-we-hardly-knew-ye
Jan 23, 2018
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5ef946b
Remove TLS-SNI-02 challenge type and associated refs.
3441d44
Restore urn:ietf:params:acme:error:tls
1b93b10
Merge remote-tracking branch 'ietf/master' into cpu-tls-sni-02-we-har…
0bb71a0
Add tls-sni tombstones to IANA concerns validations methods.
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @kelunik that it would be good to have a tombstone here. The standard practice is to have a "reserved" entry in the registry, so that you don't conflict later, but you also don't define it. Here, I think the right row would be:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bifurcation Shouldn't there be one for
tls-sni-01
by the same logic? Should I add both in this PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added both in 0bb71a0 - I can drop one if there's a reason we should only have a tombstone for tls-sni-02.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed OOB this addresses @bifurcation's comment.